[PATCH V2 1/2] nvme/{rc,002,016,017,030,031}: introduce --resv_enable argument

[Daniel Wagner]

On Tue, Jan 23, 2024 at 10:54:07AM +0000, Shinichiro Kawasaki wrote:
> On Jan 17, 2024 / 16:17, Guixin Liu wrote:
> > Add an optional argument --resv_enable to _nvmet_target_setup() and
> > propagate it to _create_nvmet_subsystem() and _create_nvmet_ns().
> > 
> > One can call functions with --resv_enable to enable reservation
> > feature on a specific namespace.
> > 
> > Signed-off-by: Guixin Liu <kanie at linux.alibaba.com>
> 
> Thanks, looks good to me.
> 
> Daniel, could you take a look in this patch? I think it is consistent with your
> work on _nvme_connect_subsys() and _nvmet_target_setup() in the past.

It teaches _create_nvmet_ns and _create_nvmet_subsystem to parse for
arguments as we have for the function you named. This makes these
function a bit more flexible to use. Looks good to me. Thanks!

Reviewed-by: Daniel Wagner <dwagner at suse.de>