> + list_for_each_entry_rcu(tmpassoc, &tgtport->assoc_list, a_list) { please avoid the overly long line. Also in general the (rcu)lock, list walk to find something, return patterns tend to benefit from being factored into a little helper. Not sure if that really fits here, though.