[PATCH 03/14] block: add an API to atomically update queue limits

John Garry john.g.garry at oracle.com
Tue Jan 30 07:05:17 PST 2024


On 30/01/2024 14:41, Christoph Hellwig wrote:
>>> +	/*
>>> +	 * The actual max_sectors value is a complex beast and also takes the
>>> +	 * max_dev_sectors value (set by SCSI ULPs) and a user configurable
>>> +	 * value into account.  The ->max_sectors value is always calculated
>>> +	 * from these, so directly setting it won't have any effect.
>>> +	 */
>>> +	max_hw_sectors = min_not_zero(lim->max_hw_sectors,
>>> +				lim->max_dev_sectors);
>> nit: maybe we should use a different variable for this for sake of clarity
> What variable name would work better for you?

Maybe max_dev_sectors. No big deal to keep as is.

> 
>>> +	/*




More information about the Linux-nvme mailing list