[PATCHv2 1/3] nvme-tcp: show hostnqn when connecting to tcp target

[Sagi Grimberg]

On 1/29/24 17:31, John Meneghini wrote:
>
> On 1/29/24 10:10, Keith Busch wrote:
>> On Mon, Jan 29, 2024 at 04:18:14PM +0200, Sagi Grimberg wrote:
>>>
>>>> Log hostnqn when connecting to nvme target.
>>>> As hostnqn could be changed, logging this information
>>>> in syslog at appropriate time may help in troubleshooting.
>>>
>>> hostnqn is available via sysfs, why do we need to log it?
>>
>> I personally haven't encountered an issue where these patches would have
>> helped, but sometimes a dmesg is all you get with a bug report.
>
> Yes, exactly. dmesg is the first place people look and often times 
> it's the only thing available.

Its going to create overly long log lines... but if you find it useful I'm
fine with it.

>
> Reviewed-by: John Meneghini <jmeneghi at redhat.com>

Reviewed-by: Sagi Grimberg <sagi at grimberg.me>