[PATCH 2/3] nvme: simplify __nvme_submit_sync_cmd() calling conventions

Christoph Hellwig hch at lst.de
Sun Jan 28 21:59:02 PST 2024


On Sat, Jan 27, 2024 at 10:37:45AM +0100, hare at kernel.org wrote:
> From: Hannes Reinecke <hare at suse.de>
> 
> Instead of having two arguments for 'flags' and 'at_head'
> for __nvme_submit_sync_cmd() combine them into a single
> 'flags' argument and use function-specific values to
> indicate what should be set within the function.

I'm not sure it's simplifying per se, but changing the calling
convention ahead of adding even more flags.

You can also use up to 73 characters for your commit log.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the Linux-nvme mailing list