[PATCH 5/8] nvme: sync the namespace scanning during ctrl start

Sagi Grimberg sagi at grimberg.me
Wed Jan 24 05:10:34 PST 2024


>>> @@ -4537,9 +4536,10 @@ void nvme_start_ctrl(struct nvme_ctrl *ctrl)
>>>           nvme_change_uevent(ctrl, "NVME_EVENT=rediscover");
>>>       if (ctrl->queue_count > 1) {
>>> -        nvme_queue_scan(ctrl);
>>> +        nvme_queue_scan_sync(ctrl);
>>>           nvme_unquiesce_io_queues(ctrl);
>>>           nvme_mpath_update(ctrl);
>>> +        nvme_kick_requeue_lists(ctrl);
>>>       }
>>
>> I really don't think its a good idea to block ctrl start
>> like that.
> 
> like how ? scan_sync ?

Yes



More information about the Linux-nvme mailing list