[PATCH 7/8] nvme-fabrics: add option to disallow T10-PI offload

[Christoph Hellwig]

On Mon, Jan 22, 2024 at 04:28:53PM +0100, Daniel Wagner wrote:
> On Mon, Jan 22, 2024 at 04:27:08PM +0100, Daniel Wagner wrote:
> > On Mon, Jan 22, 2024 at 05:17:11PM +0200, Max Gurtovoy wrote:
> > > > What about 'enable_pi' instead of the inverted boolean logic?
> > > 
> > > we can't change the default behavior (that is "enable" by default).
> > 
> > But couldn't we just have
> > 
> >     enable_pi = true
> > 
> > as default then? This should be the same as
> > 
> >    disallow_pi = false
> > 
> > ?
> 
> Ah, I get it now. This interface doesn't work this way.

The match_table_t infrastructure does allow checking for paramter
values, including boolean ones.  And this would indeed be a good
use case for that.  Extending the existing boolean only own
flags to that would be nice as well.