[PATCH V2 0/2] *** Implement the NVMe reservation feature ***
Guixin Liu
kanie at linux.alibaba.com
Wed Jan 17 00:22:24 PST 2024
The version is wrong, please ignore this.
Best regards,
Guixin Liu
在 2024/1/17 16:15, Guixin Liu 写道:
> Hi guys,
> I've implemented the NVMe reservation feature. Please review it, all
> comments are welcome as usual.
>
> Changes from v2 to v3:
> - Use rcu instead of rwlock to make IO path run faster, and put the rtype
> into the struct nvmet_pr_registrant.
>
> - Limit the resv_log_list to 128.
>
> - Change generation to atomic64.
>
> - Put register rkey check to a warpper.
>
> - Change nr_avl_pages to nr_pages.
>
> - Use NVME_SC_SUCCESS instead of 0.
>
> - Change kmalloc param to let it not sleep in mutex lock.
>
>
> Changes from v1 to v2:
> - Implement the reservation notification report, includes registration
> preempted, reservation released and reservation preempted.
> And also handle the reservation log page avaliable event and send get
> reservation log page command to clear log page at host.
>
> - Put the reservation check access after validate opcode. And remove
> opcodes which nvmet not implement yet check.
> Now there is no admin opcode nvmet implemented needs reservation check,
> so I dont add reservation check to admin command path.
> Next we need to do reservation check includes the situation of nsid is
> 0xffffffff at each admin command path, if it is needed.
>
> - Add reservation commands support in nvmet_get_cmd_effects_nvm().
>
> - From Chaitanya, change the local variable tree style to make it cleaner,
> and add some comments about NVMe spec.
> And also change others advice from chaitanya.
>
> - Put the nvmet_pr_check_cmd_access and nvmet_parse_pr_cmd into reservation
> enable check warp.
>
> - Remove kmem_cache instead to use kmalloc and kfree.
>
> - Change others advice from Sagi.
>
> - Add a blktest test case, this patch will be sent before these series of
> pathes.
>
> Guixin Liu (2):
> nvmet: support reservation feature
> nvmet: unify aer type enum
>
> drivers/nvme/target/Makefile | 2 +-
> drivers/nvme/target/admin-cmd.c | 14 +-
> drivers/nvme/target/configfs.c | 27 +
> drivers/nvme/target/core.c | 53 +-
> drivers/nvme/target/discovery.c | 2 +-
> drivers/nvme/target/nvmet.h | 33 ++
> drivers/nvme/target/pr.c | 979 ++++++++++++++++++++++++++++++++
> include/linux/nvme.h | 54 +-
> 8 files changed, 1148 insertions(+), 16 deletions(-)
> create mode 100644 drivers/nvme/target/pr.c
>
More information about the Linux-nvme
mailing list