[PATCH] nvme-tcp: Do not terminate commands when in RESETTING

Keith Busch kbusch at kernel.org
Thu Jan 11 08:15:54 PST 2024


On Thu, Jan 11, 2024 at 08:29:29AM +0100, hare at kernel.org wrote:
> +	if (ctrl->state == NVME_CTRL_RESETTING && qid > 0) {
> +		/* Avoid interfering with firmware download */
> +		if (!WARN_ON(work_pending(&ctrl->fw_act_work)))
> +			return BLK_EH_RESET_TIMER;
> +	}
> +
>  	if (ctrl->state != NVME_CTRL_LIVE) {

Unfortunately I submitted a fix late in 6.7 that changes all the
ctrl->state checks to use the READ_ONCE helper. Let's wait for block
tree's 6.8 to sync back to mainline, then redo this patch with those
updates included to avoid the conflicts.



More information about the Linux-nvme mailing list