[PATCHv3] nvme-pci: enhance timeout kernel log

Keith Busch kbusch at kernel.org
Mon Jan 8 08:17:10 PST 2024


On Sun, Jan 07, 2024 at 02:26:54AM +0200, Max Gurtovoy wrote:
> On 05/01/2024 20:20, Keith Busch wrote:
> >   	 * returned to the driver, or if this is the admin queue.
> >   	 */
> > +	opcode = nvme_req(req)->cmd->common.opcode;
> >   	if (!nvmeq->qid || iod->aborted) {
> >   		dev_warn(dev->ctrl.device,
> > -			 "I/O %d QID %d timeout, reset controller\n",
> > -			 req->tag, nvmeq->qid);
> > +			 "I/O tag %d (%04x) opcode %s %x QID %d timeout, reset controller\n",
> 
> maybe:
> 
> "I/O tag %d (%04x) opcode %#x (%s) QID %d timeout, reset controller\n",
> 
> I'm sending patches to align rdma and tcp to print tag and cid as well.
> 
> otherwise looks good,
> 
> Reviewed-by: Max Gurtovoy <mgurtovoy at nvidia.com>

Thanks for the suggestion. Applied to nvme-6.8.



More information about the Linux-nvme mailing list