[PATCH] nvme: respect user max_discard_sectors setting

Christoph Hellwig hch at lst.de
Mon Jan 8 00:26:57 PST 2024


On Fri, Jan 05, 2024 at 09:07:40AM -0700, Keith Busch wrote:
> > blk_queue_max_discard_sectors updates the hardware and user limit.
> > It's a bit of a mess, but Jens didn't quite like my half-hearted fix
> > last time.  If we want to do this properly we probably need a separate
> > user limit and recalculate the effective limit when either the hw or
> > user limit changes.  For early in the 6.9 merge window I plan to redo
> > how all the limits are set, and that should give us a better opportunity
> > for these kinds of things
> 
> Cool, I look forward to seeing what improvements you have in mind for
> this error prone area. In the meantime, is this patch okay with you or
> is that a 'Nak'?

It's not a hard NAK, but I think this actually leaves us in a slightly
worse position than before.  So in doubt I'd not merge it.



More information about the Linux-nvme mailing list