[PATCH 03/10] nvme-fabrics: move queue size definitions to common header

Sagi Grimberg sagi at grimberg.me
Mon Jan 1 03:20:01 PST 2024


>>> These definitions will be used by host and target fabrics drivers. Move
>>> them to a common place.
>>
>> Don't see why these should in any way be common.
> 
> why not ?
> why should we define these values separately for hosts and targets ?

Because the host and the target are separate systems. Don't know why
they should share the same defines for something like this.

> 
>>
>>>
>>> In the future we can introduce a common nvme-fabrics header to ease on
>>> the maintenance of the global nvme.h header.
>>
>> nvme.h is the wrong place IMO.
> 
> I've mentioned that it will be better to create 
> include/linux/nvme-fabrics.h file for common definitions for fabrics 
> drivers.
> But we can do it incrementally.

I still think that nvme.h is the wrong place for this. But if others
don't mind then fine.



More information about the Linux-nvme mailing list