[PATCH] nvme: authentication error are always non-retryable

[Hannes Reinecke]

On 2/23/24 14:29, Daniel Wagner wrote:
> On Fri, Feb 23, 2024 at 11:58:04AM +0100, hare at kernel.org wrote:
>> From: Hannes Reinecke <hare at suse.de>
>>
>> Any authentication errors which are generated internally are always
>> non-retryable, so set the DNR bit to ensure they are not retried.
> 
> This still keeps nvme-fc in the retry loop. It fails with -126 which is
> -ENOKEY:
> 
> [ 2267.185691] nvme nvme0: qid 0: no key
> [ 2267.187596] nvme nvme0: qid 0: authentication setup failed
> [ 2267.188866] nvme nvme0: NVME-FC{0}: create_assoc failed, assoc_id 2a3022dff0fe0000 ret -126
> 
Aw. Bugger.
Of course we do retry, as negative transport errors are considered 
retryable. Curiously enough, negative _NVMe_ errors are considered 
non-retryable. Hmph. We may want to work on that.

Cheers,

Hannes