[PATCH] nvmet: nvmet.h configfs helper cleanup

Chaitanya Kulkarni chaitanyak at nvidia.com
Mon Feb 12 23:43:37 PST 2024


On 2/11/24 22:59, Christoph Hellwig wrote:
> On Sun, Feb 11, 2024 at 03:39:49PM -0800, Chaitanya Kulkarni wrote:
>> Functions to_nvmet_ns(), to_ana_group(), to_subsys(), to_host() and
>> namespaces_to_subsys() are only used in target/configfs.c, move it
>> to the appropriate file instead of bloating common header.
> Does it matter?  I find having the helpers to do a container_of right
> next to the structures they are used on pretty helpful.
>

hmmm, from what I know it is a bad practice to carry private interface
in header file vs prioritizing the readability, please disregard this
patch if it is going to create any inconvenience.

-ck




More information about the Linux-nvme mailing list