[PATCH] nvme-fabrics: fix I/O connect error handling

Christoph Hellwig hch at lst.de
Mon Feb 12 21:53:05 PST 2024


On Thu, Feb 08, 2024 at 03:31:25AM -0800, Chaitanya Kulkarni wrote:
> In nvmf_connect_io_queue(), if connect I/O command fails, we log the
> error and continue for authentication. This overrides error captured
> from __nvme_submit_sync_cmd(), causing wrong return value.
> 
> Add goto out_free_data after logging connect error to fix the issue.
> 
> Signed-off-by: Chaitanya Kulkarni <kch at nvidia.com>
> ---
> 
> blktests is passing with this patch :-

Does this imply it didn't before?  In general a Fixes tag would be
more useful than a test log..




More information about the Linux-nvme mailing list