[PATCH] nvme: move passthrough logging attribute to head
Keith Busch
kbusch at kernel.org
Tue Feb 6 21:54:04 PST 2024
On Wed, Feb 07, 2024 at 04:02:42AM +0000, Chaitanya Kulkarni wrote:
> On 2/6/24 09:50, Keith Busch wrote:
> > From: Keith Busch <kbusch at kernel.org>
> >
> > The namespace does not have attributes, but the head does. Move the new
> > attribute to that structure instead of dereferncing the wrong type.
> >
> > And while we're here, fix the reverse-tree coding style.
> >
> > Fixes: 9f079dda14339e ("nvme: allow passthru cmd error logging")
> > Reported-by: Tasmiya Nalatwad <tasmiya at linux.vnet.ibm.com>
> > Cc: Alan Adamson <alan.adamson at oracle.com>
> > Signed-off-by: Keith Busch <kbusch at kernel.org>
> > ---
> >
>
> Looks good.
>
> Reviewed-by: Chaitanya Kulkarni <kch at nvidia.com>
>
> BTW I've also posted comment correction patch with Alan's review in this
> area, please have a look.
Right, I saw that but the comments would need to be updated again after
this fix. I'll take another look tomorrow and maybe just change it when
applying.
More information about the Linux-nvme
mailing list