On Wed, Aug 28, 2024 at 02:21:29PM +0200, Maurizio Lombardi wrote: > + if (min_nsid >= NVME_NSID_ALL - 1) { It would almost seem cleaner to check for the two magic constant. Either way please put a comment in with the spec reference as the code is rather non-obvious with out.