[PATCH] nvme-pci: allocate tagset on reset if necessary

Christoph Hellwig hch at lst.de
Mon Aug 26 22:49:23 PDT 2024


On Mon, Aug 26, 2024 at 11:27:19AM -0700, Keith Busch wrote:
> +	if (!dev->ctrl.tagset) {
> +		nvme_alloc_io_tag_set(&dev->ctrl, &dev->tagset, &nvme_mq_ops,
> +				nvme_pci_nr_maps(dev), sizeof(struct nvme_iod));
> +	} else {
> +		blk_mq_update_nr_hw_queues(&dev->tagset, dev->online_queues - 1);

Overly long line here.  Maybe just return early after the allocation
above?

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch at lst.de>




More information about the Linux-nvme mailing list