[PATCH 3/9] nvme: add nvme_auth_generate_digest()

[Sagi Grimberg]

Your patch is not formatted correctly.
Please create a proper patch and use git-send-email to send it to
the mailing list.


On 21/08/2024 13:18, Mark O'Donovan wrote:
> +	hmac_name = nvme_auth_hmac_name(hmac_id);
> +	if (!hmac_name) {
> +		pr_warn("%s: invalid hash algoritm %d\n",
> algoritm should be algorithm.
> This typo is also present in other patches.
>
>
> +	ret = base64_encode(digest, digest_len, hmac);
> +	if (ret < hmac_len)
> +		ret = -ENOKEY;
> +	*ret_digest = hmac;
> +	ret = 0;
> The value assigned to ret in the if statement will be overwritten.
> It looks like a goto is missing.
>
> Regards,
> Mark
>