[PATCH] nvme: move stopping keep-alive into nvme_uninit_ctrl()

[Hannes Reinecke]

On 8/12/24 17:14, Keith Busch wrote:
> On Mon, Aug 12, 2024 at 01:56:01PM +0200, Hannes Reinecke wrote:
>> On 8/9/24 15:54, Ming Lei wrote:
>>> @@ -4612,7 +4612,6 @@ void nvme_stop_ctrl(struct nvme_ctrl *ctrl)
>>>    {
>>>    	nvme_mpath_stop(ctrl);
>>>    	nvme_auth_stop(ctrl);
>>> -	nvme_stop_keep_alive(ctrl);
>>>    	nvme_stop_failfast_work(ctrl);
>>>    	flush_work(&ctrl->async_event_work);
>>>    	cancel_work_sync(&ctrl->fw_act_work);
>>
>> Huh? What happened here?
>> Commit 4733b65d82bd ("nvme: start keep-alive after admin queue setup")
>> has _exactly_ the same hunk.
>> Someone else must've changed it afterwards, so please update the 'fixes'
>> tag to refer to the correct commit.
> 
> Yes, someone did change it :)
> 
>    commit 3af755a46881c32fecaecfdeaf3a8f0a869deca5
>    Author: Hannes Reinecke <hare at suse.de>
>    Date:   Tue Nov 21 09:01:03 2023 +0100
> 
>        nvme: move nvme_stop_keep_alive() back to original position
> 
> So 4733b65d82bd moved it to the wrong place and Ming's patch is the
> correct one?

That's perfectly fine, it's just that the 'Fixes' tag doesn't tell the 
full story.
All I was asking it to update the 'Fixes' tag to the latest patch
(ie 3af755a46881 ("nvme: move nvme_stop_keep_alive() back to original 
position")) such that the poor people having to do backports can
rewind via the 'Fixes' tag and get all necessary patches.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare at suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich