[PATCH] nvmet: fix nvme status code when namespace is disabled

Christoph Hellwig hch at lst.de
Sun Apr 28 22:14:57 PDT 2024


On Sun, Apr 28, 2024 at 12:25:40PM +0300, Sagi Grimberg wrote:
> If the user disabled a nvmet namesapce, it is removed from

s/namesapce/namespace/

(lines also look a little short here, maybe use up all 73 chars
when refreshing it).

> +		if (nvmet_subsys_nsid_exists(subsys, nsid))
> +			return NVME_SC_INTERNAL_PATH_ERROR;
> +		else
> +			return NVME_SC_INVALID_NS | NVME_SC_DNR;

No need for an else after a return.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch at lst.de>



More information about the Linux-nvme mailing list