nvme-cli spdk plugin

Sagi Grimberg sagi at grimberg.me
Thu Apr 18 02:22:56 PDT 2024



On 17/04/2024 17:31, Jens Axboe wrote:
> On 4/17/24 8:26 AM, Christoph Hellwig wrote:
>> On Wed, Apr 17, 2024 at 10:33:17AM +0200, Daniel Wagner wrote:
>>> There is a PR [1] pending, adding a spdk plugin for nvme-cli. The
>>> problem this new plugin tries to solve is, that with the recent change
>>> to use sysfs only for discovering the nvme subystem, nvme-cli
>>> lost support for spdk.
>>>
>>> My question is, should we have a special plugin for 'list' and
>>> 'list-subsystem' or should we try to get this somehow integrated into
>>> the existing code? So that 'list' just works?
>> І don't think nvme-cli should deal with anything that is not driven
>> by the kernel nvme driver.
> Exactly, why on earth would we care about spdk at all in the first
> place, nvme-cli or not.
>

As long as it does not introduce a maintenance overhead I don't particularly
care. My suggestion was simply to make nvme-cli operate on a path-prefix,
which is a very minor change. One can even argue that its justified for 
a container
bind mounts (although I've never seen someone bind mount to targets other
than /sys and /dev ...)

In any event, if the spdk folks can make their devices interop with 
nvme-cli, I personally
am not strictly against it if it doesn't require a burden on nvme-cli.



More information about the Linux-nvme mailing list