[PATCH for 5.15.y] nvme: fix miss command type check

Greg Kroah-Hartman gregkh at linuxfoundation.org
Mon Apr 8 04:32:51 PDT 2024


On Sun, Apr 07, 2024 at 06:15:28PM +0900, Tokunori Ikegami wrote:
> From: "min15.li" <min15.li at samsung.com>
> 
> commit 31a5978243d24d77be4bacca56c78a0fbc43b00d upstream.
> 
> In the function nvme_passthru_end(), only the value of the command
> opcode is checked, without checking the command type (IO command or
> Admin command). When we send a Dataset Management command (The opcode
> of the Dataset Management command is the same as the Set Feature
> command), kernel thinks it is a set feature command, then sets the
> controller's keep alive interval, and calls nvme_keep_alive_work().
> 
> Signed-off-by: min15.li <min15.li at samsung.com>
> Reviewed-by: Kanchan Joshi <joshi.k at samsung.com>
> Reviewed-by: Christoph Hellwig <hch at lst.de>
> Signed-off-by: Keith Busch <kbusch at kernel.org>
> Fixes: b58da2d270db ("nvme: update keep alive interval when kato is modified")
> Signed-off-by: Tokunori Ikegami <ikegami.t at gmail.com>
> ---
>  drivers/nvme/host/core.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Both now queued up, thanks.

greg k-h



More information about the Linux-nvme mailing list