[PATCH] nvme-multipath: don't inherit LBA-related fields for the multipath node

Nilay Shroff nilay at linux.ibm.com
Tue Apr 2 06:21:02 PDT 2024


Hi Keith,

On 3/22/24 21:52, Keith Busch wrote:
> On Fri, Mar 22, 2024 at 07:08:19AM +1000, Christoph Hellwig wrote:
>> Linux 6.9 made the nvme multipath nodes not properly pick up changes when
>> the LBA size goes smaller after an nvme format.  This is because we now
>> try to inherit the queue settings for the multipath node entirely from
>> the individual paths.  That is the right thing to do for I/O size
>> limitations, which make up most of the queue limits, but it is wrong for
>> changes to the namespace configuration, where we do want to pick up the
>> new format, which will eventually show up on all paths once they are
>> re-queried.
>>
>> Fix this by not inheriting the block size and related fields and always
>> for updating them.
>>
>> Fixes: 8f03cfa117e0 ("nvme: don't use nvme_update_disk_info for the multipath disk")
> 
> Applied to nvme-6.9. This just missed yesterday's pull, but at least
> it's queued up for the next one.

I found this one couldn't made into 6.9-rc2. So are we planning to queue this fix
for the next rc?

Thanks,
--Nilay




More information about the Linux-nvme mailing list