[PATCH v15 05/20] nvme-tcp: Add DDP offload control path
Aurelien Aptel
aaptel at nvidia.com
Mon Sep 18 05:53:34 PDT 2023
Sagi Grimberg <sagi at grimberg.me> writes:
> Perhaps you should bundle them together:
> ctrl->ddp_netdev = nvme_tcp_get_ddp_netdev_with_limits(ctrl);
> if (ctrl->ddp_netdev)
> nvme_tcp_ddp_apply_ctrl_limits(ctrl);
> [...]
Sure, we will rewrite it this way.
>
> And perhaps its time to introduce nvme_tcp_stop_admin_queue()?
> static void nvme_tcp_stop_admin_queue(struct nvme_ctrl *nctrl) {
> struct nvme_tcp_ctrl *ctrl = to_tcp_ctrl(nctrl);
>
> nvme_tcp_stop_queue(nctrl, 0);
> dev_put(ctrl->ddp_netdev);
> }
Ok, we will add nvme_tcp_stop_admin_queue() and use it to replace calls
to nvme_tcp_stop_queue(ctrl, 0).
Thanks
More information about the Linux-nvme
mailing list