[PATCH V7 1/1] nvme: allow passthru cmd error logging
Christoph Hellwig
hch at lst.de
Mon Sep 4 23:53:48 PDT 2023
> if (req->q->queuedata)
> req->timeout = NVME_IO_TIMEOUT;
> - else /* no queuedata implies admin queue */
> + else { /* no queuedata implies admin queue */
> req->timeout = NVME_ADMIN_TIMEOUT;
> + if (!nr->ctrl->passthru_err_log_enabled)
> + req->rq_flags |= RQF_QUIET;
> + }
>
> /* passthru commands should let the driver set the SGL flags */
> cmd->common.flags &= ~NVME_CMD_SGL_ALL;
> @@ -687,8 +720,7 @@ void nvme_init_request(struct request *req, struct nvme_command *cmd)
> if (req->mq_hctx->type == HCTX_TYPE_POLL)
> req->cmd_flags |= REQ_POLLED;
> nvme_clear_nvme_request(req);
> - req->rq_flags |= RQF_QUIET;
Isn't thisw now dropping the RQF_QUIET flag I/O commands that we
previously set? While we're at it, why do we only allow passthrough
error logging for admin commands anyway?
More information about the Linux-nvme
mailing list