Looks good: Reviewed-by: Christoph Hellwig <hch at lst.de> > Personally I prefer v1. Pick the one you prefer :) I think we should be consistent with one style or another in a given function. Otherwise I wouldn't even have mentioned it.