[PATCH 0/4] nvme: start keep-alive after admin queue setup

[Keith Busch]

On Mon, Oct 23, 2023 at 11:54:37AM +0200, Hannes Reinecke wrote:
> But we start keep alive unconditionally nowadays; each and every
> host driver (including PCI) is calling into nvme_start_ctrl(),
> which calls nvme_start_keep_alive() without any checks.

I see nvme_start_keep_alive() is always called, but that checks
'ctrl->kato' which will always be 0 for PCI.
 
> Be it as it may, tying it into the state transition won't work
> as the 'CONNECTING' state is entered _before_ any queues are setup,
> so starting keep-alive here would be too early.

That's just IO eueues, right? Keep-alive is an admin command, and the
admin queue should be up in the CONNECTING state.