[PATCHv2] nvmet-tcp: do not try to cancel uninitialized tls_handshake_tmo_work

Jens Axboe axboe at kernel.dk
Thu Oct 19 07:17:28 PDT 2023


On 10/19/23 7:34 AM, Hannes Reinecke wrote:
> The TLS handshake timeout workqueue is only initialized if TLS
> is configured, so we shouldn't try to de-initialize it
> unconditionally.

Please fix this properly rather than working around it. Either put the
work item inside CONFIG_NVME_TARGET_TCP_TLS so that any unintended use
can't happen in the future, or just initialize the darn thing at setup
time rather than have this conditional.

-- 
Jens Axboe




More information about the Linux-nvme mailing list