[PATCH v16 04/12] block: add emulation for copy
Nitesh Jagadeesh Shetty
nj.shetty at samsung.com
Wed Oct 18 03:08:48 PDT 2023
On 26/09/23 03:37PM, Nitesh Jagadeesh Shetty wrote:
>>>+ write_bio->bi_iter.bi_size = chunk;
>>>+ ret = submit_bio_wait(write_bio);
>>>+ kfree(write_bio);
>>
>>blk_mq_map_bio_put(write_bio) ?
>>or bio_uninit(write_bio); kfree(write_bio)?
>>
>>hmm...
>>It continuously allocates and releases memory for bio,
>>Why don't you just allocate and reuse bio outside the loop?
>>
>
>Agree, we will update this in next version.
>
Reusing the bio won't work in cases where the bio gets split.
So we decided to keep the previous design.
Thank you,
Nitesh Shetty
More information about the Linux-nvme
mailing list