[PATCH 6/7] fs/sysfs/group: make attribute_group pointers const

Max Kellermann max.kellermann at ionos.com
Mon Oct 9 10:30:24 PDT 2023


On Mon, Oct 9, 2023 at 7:26 PM Greg Kroah-Hartman
<gregkh at linuxfoundation.org> wrote:
> I'm all for doing this type of work, but this is going to be rough.  You
> sent patch 6/7 that hit almost all subsystems at once :(

I wasn't sure whether splitting patches was desired. In the past, I
was often asked to fold multiple patches into one. There are so many
opinions :-) but I'll gladly change to whatever is asked.

> "*const*groups"?   That's a parsing nightmare, really hard for humans to
> read and understand.  Doesn't checkpatch complain about this?

No. I'll change the coding style (and maybe take some time to fix checkpatch?)



More information about the Linux-nvme mailing list