[PATCH] nvme: move nvme_stop_keep_alive() back to original position

[Keith Busch]

On Wed, Nov 22, 2023 at 10:16:09AM +0200, Sagi Grimberg wrote:
> 
> > > > > Stopping keep-alive not only stops the keep-alive workqueue,
> > > > > but also needs to be synchronized with I/O termination as we
> > > > > must not send a keep-alive command after all I/O had been
> > > > > terminated.
> > > > > So to avoid any regressions move the call to stop_keep_alive()
> > > > > back to its original position and ensure that keep-alive is
> > > > > correctly stopped failing to setup the admin queue.
> > > > > 
> > > > > Fixes: 4733b65d82bd ("nvme: start keep-alive after admin queue setup")
> > > > 
> > > > It should be folded in I guess. I suggest to either suggest an
> > > > alternative phrasing of the patch or resend an alternative patch
> > > > set.
> > > > 
> > > Well, the original patch has already been merged to the nvme-6.7 tree,
> > > so I've attached the 'Fixes' tag.
> > > But let me know how you'd like to play it.
> > 
> > It's not just in nvme-6.7; it's merged upstream too. We can't squash it
> > now, so is it okay to apply this update as-is for the next pull request?
> > I'm going to send the next one out tomorrow before US holiday.
> 
> Right, I didn't reach the PR email that was sent. Lets send the patch
> as is. You can add my:
> Reviewed-by: Sagi Grimberg <sagi at grimberg.me>

Thanks, queued up now for nvme-6.7.