[PATCH blktests 2/2] nvme: do not print subsystem NQN to stdout

Shinichiro Kawasaki shinichiro.kawasaki at wdc.com
Fri Nov 17 00:46:16 PST 2023


On Nov 08, 2023 / 15:47, Shin'ichiro Kawasaki wrote:
> From: Hannes Reinecke <hare at suse.de>
> 
> The subsystem NQN might be changed from the default value, but
> that shouldn't cause the tests to fail. So don't register the
> subsystem NQN in the 'out' files to avoid a false positive.
> 
> Signed-off-by: Hannes Reinecke <hare at suse.de>
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki at wdc.com>

Today I noticed that this change will hide the failures due to unset kernel
config NVME_HOST_AUTH [1]. This change drops check for all of the "nvme
disconnect" command output, then it reduces the ability to catch failures.

Now I think it's the better to remove only subsystem NQN part from the "nvme
disconnect" command output so that we can still detect the failures. Will
prepare v2 with this approach.

[1] https://lore.kernel.org/linux-nvme/CAHj4cs8yZ4-BXqTK4W0UsPpmc2ctCD=_mYiwuAuvcmgS3+KJ8g@mail.gmail.com/


More information about the Linux-nvme mailing list