[PATCHv5 0/2] nvme: fixup module compilation

Keith Busch kbusch at meta.com
Tue Nov 7 10:14:19 PST 2023


From: Keith Busch <kbusch at kernel.org>

Trying to sort this out before rc1, here's my take on bringing this
together after reading through the history on it.

Changes from previous version:

I updated patch one's keyring stub check to use IS_ENABLED rather than
ifdef. The patch makes CONFIG_NVME_SYMBOL possible to be a module now,
so ifdef doesn't work correctly with that.

For patch 2, I removed all the Kconfig stuff from the previous,
otherwise it's the same. nvme-keyring will not be built-in unless a
dependency is also built-in, otherwise it will be a module if another
module depends on it.

Arnd Bergmann (1):
  nvme: common: make keyring and auth separate modules

Hannes Reinecke (1):
  nvme: keyring: fix conditional compilation

 drivers/nvme/Makefile         |  2 +-
 drivers/nvme/common/Kconfig   |  7 ++-----
 drivers/nvme/common/Makefile  |  7 ++++---
 drivers/nvme/common/keyring.c | 11 +++++++----
 drivers/nvme/host/Kconfig     |  2 --
 drivers/nvme/host/core.c      |  9 +--------
 drivers/nvme/target/Kconfig   |  2 --
 include/linux/nvme-keyring.h  | 10 +---------
 8 files changed, 16 insertions(+), 34 deletions(-)

-- 
2.34.1




More information about the Linux-nvme mailing list