[PATCH] nvme-pci : redundancies in nvme_alloc_queue and nvme_init_queue

irvin cote irvincoteg at gmail.com
Sat May 20 19:47:37 PDT 2023


I'm trying to resend the patch but somehow all the new attempts seem
to bind to this thread...

On Sat, 20 May 2023 at 23:46, Irvin Cote <irvincoteg at gmail.com> wrote:
>
> cq_head cq_phase and q_db are getting set in nvme_alloc_queue
> and in nvme_init_queue, make it so that they are only set once in
> nvme_init_queue.
>
> Signed-off-by: Irvin Cote <irvincoteg at gmail.com>
> ---
>  drivers/nvme/host/pci.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 32244582fdb0..49ae26980a0f 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -1533,9 +1533,6 @@ static int nvme_alloc_queue(struct nvme_dev *dev, int qid, int depth)
>         nvmeq->dev = dev;
>         spin_lock_init(&nvmeq->sq_lock);
>         spin_lock_init(&nvmeq->cq_poll_lock);
> -       nvmeq->cq_head = 0;
> -       nvmeq->cq_phase = 1;
> -       nvmeq->q_db = &dev->dbs[qid * 2 * dev->db_stride];
>         nvmeq->qid = qid;
>         dev->ctrl.queue_count++;
>
> --
> 2.39.2
>



More information about the Linux-nvme mailing list