[PATCH v2 3/3] nvme: improve handling of long keep alives

Uday Shankar ushankar at purestorage.com
Fri May 19 10:42:24 PDT 2023


On Thu, May 18, 2023 at 12:01:33PM +0300, Sagi Grimberg wrote:
> > +	/* Subtract off the keepalive RTT so nvme_keep_alive_work runs
> > +	 * at the desired frequency. */
> > +	if (rtt <= delay)
> > +		delay -= rtt;
> > +	else
> > +		delay = 0;
> This should probably log a warning or something... The controller has
> such a slow response time to keep-alive that it exceeds the delay...

Good idea. Added it in v3.



More information about the Linux-nvme mailing list