nvme host complete request tracing

Engel, Amit Amit.Engel at Dell.com
Wed May 17 09:27:37 PDT 2023


Hello,

nvme/host/core.c trace_nvme_complete_rq() is being called immediately when entering nvme_complete_rq()
As I understand it, the idea behind this trace is to trace every single nvme request that is being completed.
but this is actually not accurate since there are several options for a request as part of this function:
COMPLETE, RETRY, FAILOVER

In order to better understand the status per nvme request I think it’s better to have a separate trace per each case, something like:
trace_nvme_end_rq(req), trace_nvme_retry_rq(req), trace_nvme_failover_rq(req) etc.

Would love to hear your inputs.

Thanks,
Amit E


Internal Use - Confidential


More information about the Linux-nvme mailing list