[PATCH v2 1/1] nvme: move sysfs code to a dedicated sysfs.c file

Keith Busch kbusch at kernel.org
Mon May 15 07:57:16 PDT 2023


On Tue, Apr 25, 2023 at 12:12:42AM +0300, Max Gurtovoy wrote:
> The core.c file became long and hard to maintain. Create a dedicated
> file to centralize the sysfs functionality. This is a common practice to
> separate sysfs/configfs related logic from the main driver logic .c file.
> For example, in the nvmet module the configfs interface has its own
> dedicated file.
> 
> This patch does not include any functional changes.

Thanks, I applied this for 6.5 with a couple minor changes:

I merged Chaitanya's dhchap memory leak fixes first, which touched some
of this sysfs code, so I simply used the the result when moving the code
to the new file.

I also added an 'include <linux/nvme-auth.h>' in the new sysfs.c file
for when CONFIG_NVME_AUTH=y.



More information about the Linux-nvme mailing list