[PATCH 11/17] nvme-tcp: enable TLS handshake upcall

[Daniel Wagner]

 > > > > index bbaa04a0c502..2aa8fb991455 100644
> > > > > --- a/drivers/nvme/host/fabrics.c
> > > > > +++ b/drivers/nvme/host/fabrics.c
> > > > > @@ -609,6 +609,9 @@ static const match_table_t opt_tokens = {
> > > > >       { NVMF_OPT_DISCOVERY,        "discovery"        },
> > > > >       { NVMF_OPT_DHCHAP_SECRET,    "dhchap_secret=%s"    },
> > > > >       { NVMF_OPT_DHCHAP_CTRL_SECRET,    "dhchap_ctrl_secret=%s"    },
> > > > > +#ifdef CONFIG_NVME_TCP_TLS
> > > > 
> > > > This ifdef is redundant IMO.
> > > > We have to many of those already in the code and we should
> > > > reduce to be able to keep the code maintainable.
> > > > 
> > > We have been going back and forth on this, and the consensus was to
> > > _have_ a compilation flag here. This allows the userland utility
> > > nvme-cli to determine whether tls support is available on any given
> > > kernel.
> > 
> > nvme-cli will determine tls support using check for "static const
> > match_table_t opt_tokens" ?
> > 
> Yes. The table is displayed by doing a 'cat' on /dev/nvme-fabrics, and
> nvme-cli will be parsing that to figure out if a particular option is
> supported.

FWIW, here the filter code:

https://github.com/linux-nvme/libnvme/commit/d123131f2e542e5a4c046cb65a68fc1fb97ea384