[PATCH] nvmet-rdma: Suppress a class of lockdep complaints
Sagi Grimberg
sagi at grimberg.me
Tue May 9 16:26:28 PDT 2023
>> Can we fix the lockdep not to get confused
>
> Lockdep uses static keys by default. Associating a single static key
> with multiple synchronization object instances can cause false
> positives. This is why I introduced support for dynamic keys in lockdep
> about four years ago. I don't think that it is possible to make dynamic
> keys the default without changing all synchronization primitives.
>
>> or ignore it if its not a real issue ?
>
> Most lockdep reports indicate a real problem so every lockdep report
> should be reviewed. Having to review false positive complaints every
> time blocktests is run is tedious. I think it is much better to suppress
> false positive complaints (in a safe way) rather than asking everyone
> who runs blktests to review all false positive lockdep complaints every
> time blktests is run.
Agree, shutting up just this complaint would be great. This looks
perfectly fine to me.
Reviewed-by: Sagi Grimberg <sagi at grimberg.me>
More information about the Linux-nvme
mailing list