[PATCH V2 3/4] nvme-core: add missing fault-injection cleanup

[Yi Zhang]

Confirmed the issue was fixed, feel free to add:

Tested-by: Yi Zhang <yi.zhang at redhat.com>


On Fri, Apr 28, 2023 at 3:40 PM Chaitanya Kulkarni <kch at nvidia.com> wrote:
>
> Add missing fault-injection cleanup in nvme_init_ctrl() in the error
> unwind path that also fixes following message for blktests:-
>
> linux-block (for-next) # grep debugfs debugfs-err.log
> [  147.853464] debugfs: Directory 'nvme1' with parent '/' already present!
> [  147.853973] nvme1: failed to create debugfs attr
> [  148.802490] debugfs: Directory 'nvme1' with parent '/' already present!
> [  148.803244] nvme1: failed to create debugfs attr
> [  148.877304] debugfs: Directory 'nvme1' with parent '/' already present!
> [  148.877775] nvme1: failed to create debugfs attr
> [  149.816652] debugfs: Directory 'nvme1' with parent '/' already present!
> [  149.818011] nvme1: failed to create debugfs attr
>
> Signed-off-by: Chaitanya Kulkarni <kch at nvidia.com>
> ---
>  drivers/nvme/host/core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 42e90d00fc40..15607281baaa 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -5201,6 +5201,7 @@ int nvme_init_ctrl(struct nvme_ctrl *ctrl, struct device *dev,
>
>         return 0;
>  out_free_cdev:
> +       nvme_fault_inject_fini(&ctrl->fault_inject);
>         cdev_device_del(&ctrl->cdev, ctrl->device);
>  out_free_name:
>         nvme_put_ctrl(ctrl);
> --
> 2.40.0
>
>


--
Best Regards,
  Yi Zhang