[PATCH v4 3/3] io_uring: Remove unnecessary BUILD_BUG_ON
Ming Lei
ming.lei at redhat.com
Thu May 4 07:40:17 PDT 2023
On Thu, May 04, 2023 at 05:18:56AM -0700, Breno Leitao wrote:
> In the io_uring_cmd_prep_async() there is an unnecessary compilation time
> check to check if cmd is correctly placed at field 48 of the SQE.
>
> This is unnecessary, since this check is already in place at
> io_uring_init():
>
> BUILD_BUG_SQE_ELEM(48, __u64, addr3);
>
> Remove it and the uring_cmd_pdu_size() function, which is not used
> anymore.
>
> Keith started a discussion about this topic in the following thread:
> Link: https://lore.kernel.org/lkml/ZDBmQOhbyU0iLhMw@kbusch-mbp.dhcp.thefacebook.com/
>
> Signed-off-by: Breno Leitao <leitao at debian.org>
> Reviewed-by: Christoph Hellwig <hch at lst.de>
Reviewed-by: Ming Lei <ming.lei at redhat.com>
Thanks,
Ming
More information about the Linux-nvme
mailing list