[PATCH v4 2/3] io_uring: Pass whole sqe to commands
Ming Lei
ming.lei at redhat.com
Thu May 4 07:29:09 PDT 2023
On Thu, May 04, 2023 at 05:18:55AM -0700, Breno Leitao wrote:
> Currently uring CMD operation relies on having large SQEs, but future
> operations might want to use normal SQE.
>
> The io_uring_cmd currently only saves the payload (cmd) part of the SQE,
> but, for commands that use normal SQE size, it might be necessary to
> access the initial SQE fields outside of the payload/cmd block. So,
Looks fine,
Reviewed-by: Ming Lei <ming.lei at redhat.com>
BTW, there might be risk[1] when accessing SQE fields which were read by
io_uring core code, and I'd suggest to document it in future.
[1] https://lore.kernel.org/io-uring/ZDlcXd4K+a2iGbnv@ovpn-8-21.pek2.redhat.com/
Thanks,
Ming
More information about the Linux-nvme
mailing list