[bug report] most of blktests nvme/ failed on the latest linux tree

[Max Gurtovoy]

On 28/06/2023 11:14, Sagi Grimberg wrote:
> 
>>>
>>>>> Yi,
>>>>>
>>>>> Do you have hostnqn and hostid files in your /etc/nvme directory?
>>>>>
>>>>
>>>> No, only one discovery.conf there.
>>>>
>>>> # ls /etc/nvme/
>>>> discovery.conf
>>>
>>> So the hostid is generated every time if it is not passed.
>>> We should probably revert the patch and add it back when
>>> blktests are passing.
>>
>> Seems like the patch is doing exactly what it should do - fix wrong 
>> behavior of users that override hostid.
>> Can we fix the tests instead ?
> 
> Right, I got confused between a provided host and the default host...
> 
> I think we need to add check that /etc/nvme/[hostnqn,hostid] exist
> in the test cases.

Right.
And if one of the files doesn't exist, generate the value.

Should it go to tests/nvme/rc ?