[PATCH V2 1/2] nvme: add generic helper to store secret

hch at lst.de hch at lst.de
Tue Jun 6 22:03:43 PDT 2023


On Tue, Jun 06, 2023 at 09:43:16AM +0300, Sagi Grimberg wrote:
> I understand, but at a point where the commonality becomes confusing
> it can get counter productive.

Agreed.  As-is I don't think the code has very sane structure after
the patch.  If we want to consolidate the code, I'd make the sectet and
key fields a two-element array, with an enum for the indices.  With
that might be possible to share the code without needing extra branches
for which case we're handling.



More information about the Linux-nvme mailing list