[PATCH blktests] nvme/{016,017}: use _check_genctr instead of _filter_discovery

Sagi Grimberg sagi at grimberg.me
Mon Jun 5 16:18:07 PDT 2023


> On May 31, 2023 / 09:07, Yang Xu wrote:
>> Since commit 328943e3 ("Update tests for discovery log page changes"),
>> blktests also include the discovery subsystem itself. But it
>> will lead these cases fails on older nvme-cli system.
> 
> Thanks for this report. What is the nvme-cli version with the issue?
> 
>>
>> To avoid this, like nvme/002, use _check_genctr to check instead of
>> comparing many discovery Log Entry output.
>>
>> Signed-off-by: Yang Xu <xuyang2018.jy at fujitsu.com>
> 
> The change looks fine to me, but I'd wait for comments by nvme developers.

I'm ok with this change, but IIRC Chaitanya wanted that we keep checking
the full log-page output...



More information about the Linux-nvme mailing list