[PATCH V3 0/3] nvmet-auth: auth send / receive cleanup

Chaitanya Kulkarni chaitanyak at nvidia.com
Mon Jun 5 02:24:02 PDT 2023


On 6/5/23 02:19, Chaitanya Kulkarni wrote:
> Hi,
>
> nvmet_execute_auth_send() and nvmet_exeucte_auth_receive() share a lot
> of common functionality such as :-
>
> 1. Checking secp/spsp values and its error handling.
> 2. Initializing transfer buffer len and its error handling.
> 2. Allocating transfer buffer and its error handling.
>
> This code is repeated in both the functions.
>
> Add common helpers with very small restructring of code to remove
> duplication of above functionality in the nvmet_exeucte_auth_receive()
> and nvmet_execute_auth_send(), it also makes code easy to read as both
> the functions are doing substantial work.
>
> Please note that this series is generated on the top of this :-
>
> commit 01cff945c026f1e245ba6401f7df2336ddbae11d (origin/nvme-6.5)
> Author: Chaitanya Kulkarni <kch at nvidia.com>
> Date:   Fri May 19 02:40:52 2023 -0700
>
>      nvme-fcloop: no need to return from void function
>      
>      Remove return at the end of void function.
>
> -ck
>
>

Please disregard this, I'll send V4, apologies for noise..

-ck




More information about the Linux-nvme mailing list