[PATCH v1 2/2] nvme: remove warning for shared ns when multipath=N

Daniel Wagner dwagner at suse.de
Wed Jul 19 01:41:47 PDT 2023


The default value for the module parameter multipath is Y, thus the user
has actively chosen to set multipath to N to trigger this warning with
shared namespaces.

There is at least one external mutlipathing module which conflict with
the native multipathing feature (Dell's PowerPath module). In such setups
the native mutlipathing is deliberate disabled but the warning
that mutlipathing is not supported is confusing users.

The warning was added in ce8d78616a6b ("nvme: warn about shared
namespaces without CONFIG_NVME_MULTIPATH"). In the mean time the config
option has been dropped. Because multipath is now always built-in and
the default is Y, just drop the warning.

Signed-off-by: Daniel Wagner <dwagner at suse.de>
---
 drivers/nvme/host/core.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index d08371967ce3..e8faee21c7f5 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -3494,11 +3494,6 @@ static int nvme_init_ns_head(struct nvme_ns *ns, struct nvme_ns_info *info)
 					info->nsid);
 			goto out_put_ns_head;
 		}
-
-		if (!multipath)
-			dev_warn(ctrl->device,
-				"Found shared namespace %d, but multipathing not supported.\n",
-				info->nsid);
 	}
 
 	list_add_tail_rcu(&ns->siblings, &head->list);
-- 
2.41.0




More information about the Linux-nvme mailing list