[PATCH] nvme: don't reject probe due to duplicate IDs for single-ported PCIe devices

[Jens Axboe]

On 7/13/23 8:54 AM, Keith Busch wrote:
> On Thu, Jul 13, 2023 at 07:32:06PM +0530, Kanchan Joshi wrote:
>> On Thu, Jul 13, 2023 at 03:30:42PM +0200, Christoph Hellwig wrote:
>>> While duplicate IDs are still very harmful, including the potential to easily
>>> see changing devices in /dev/disk/by-id, it turn out they are extremely
>>> common for cheap end user NVMe devices.
>>>
>>> Relax our check for them for so that it doesn't reject the probe on
>>> single-ported PCIe devices, but prints a big warning instead.  In doubt
>>> we'd still like to see quirk entries to disable the potential for
>>> changing supposed stable device identifier links, but this will at least
>>> allow users how have two (or more) of these devices to use them without
>>> having to manually add a new PCI ID entry with the quirk through sysfs or
>>> by patching the kernel.
>>
>> Should this go for backport? For the commit 2079f41ec6ffa.
> 
> Is it sufficient if I just append "Cc: stable..." to the commit message?

You probably want:

Fixes: 2079f41ec6ff ("nvme: check that EUI/GUID/UUID are globally unique")
Cc: stable at vger.kernel.org

and that should do the trick.

-- 
Jens Axboe