[PATCH 1/6] nvme: unquiesce io queues when removing namespaces

[Ming Lei]

On Tue, Jul 11, 2023 at 10:27:19AM +0200, Christoph Hellwig wrote:
> On Mon, Jul 10, 2023 at 11:35:50PM +0800, Ming Lei wrote:
> > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> > index 47d7ba2827ff..98fa8315bc65 100644
> > --- a/drivers/nvme/host/core.c
> > +++ b/drivers/nvme/host/core.c
> > @@ -3903,6 +3903,12 @@ void nvme_remove_namespaces(struct nvme_ctrl *ctrl)
> >  	 */
> >  	nvme_mpath_clear_ctrl_paths(ctrl);
> >  
> > +	/*
> > +	 * Unquiesce io queues so any pending IO won't hang, especially
> > +	 * those submitted from scan work
> > +	 */
> > +	nvme_unquiesce_io_queues(ctrl);
> 
> What quiesce does this pair with?

The one done during teardown of error recovery, then removal comes and breaks
the in-progress error recovery.


Thanks,
Ming